Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: Don't lose track of jobs in 'qw' status on SGE #103

Merged
merged 1 commit into from
Mar 25, 2019
Merged

BugFix: Don't lose track of jobs in 'qw' status on SGE #103

merged 1 commit into from
Mar 25, 2019

Conversation

oscarwumit
Copy link
Contributor

Add qw as a keyword when ARC determines job server status
This aviods losing track of qw jobs on pharos
Previously, if a job has qw status on pharos for extended time
(e.g. server is loaded), ARC has chances of losing track of it

@oscarwumit oscarwumit requested a review from alongd March 24, 2019 15:26
@alongd alongd changed the title bug fix: ARC lose track jobs if qw on pharos Fix losing track of jobs if qw status on SGE Mar 24, 2019
@alongd
Copy link
Member

alongd commented Mar 24, 2019

Thanks!
Please change the header of the commit message to
BugFix: Don't lose track of jobs in 'qw' status on SGE
Let me know if you think this fixes the issue you had

@codecov
Copy link

codecov bot commented Mar 24, 2019 •
edited
Loading

Codecov Report

Merging #103 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #103   +/-   ##
======================================
  Coverage    40.6%   40.6%           
======================================
  Files          22      22           
  Lines        5221    5221           
  Branches     1353    1353           
======================================
  Hits         2120    2120           
+ Misses       2759    2757    -2     
- Partials      342     344    +2
Impacted Files Coverage Δ
arc/job/ssh.py 12.97% <0%> (ø) ⬆️
arc/reaction.py 42.12% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085a9c0...761dcbd. Read the comment docs.

@oscarwumit
Copy link
Contributor Author

Thanks. I have updated the commit message. So far ARC tracks jobs as expected.

@alongd
Copy link
Member

alongd commented Mar 24, 2019 •
edited
Loading

I don't see the updated message, for me it still shows bug fix: Don't lose track of jobs in 'qw' status on SGE

@oscarwumit oscarwumit changed the title Fix losing track of jobs if qw status on SGE BugFix: Don't lose track of jobs in 'qw' status on SGE Mar 25, 2019
@oscarwumit
Copy link
Contributor Author

I changed the commit message but forget to change the header for the pull request. Now it's all updated.

@alongd
Copy link
Member

alongd commented Mar 25, 2019

Please go ahead and rebase

@oscarwumit
bug fix: Don't lose track of jobs in 'qw' status on SGE
761dcbd 
Add qw as a keyword when ARC determines job server status
This aviods losing track of qw jobs on pharos
Previously, if a job has qw status on pharos for extended time
(e.g. server is loaded), ARC has chances of losing track of it
@oscarwumit
Copy link
Contributor Author

@alongd Just rebased

alongd
alongd approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@alongd alongd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alongd alongd merged commit 4e1638b into master Mar 25, 2019
@alongd alongd deleted the server_status branch March 25, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongd alongd alongd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oscarwumit @alongd